Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Missing data in Sync Status if application never been synced #16184

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix(ui): Missing data in Sync Status if application never been synced #16184

merged 1 commit into from
Oct 31, 2023

Conversation

rpelczar
Copy link
Contributor

@rpelczar rpelczar commented Oct 31, 2023 •
edited
Loading

Before:
image

After:
image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@rpelczar rpelczar requested a review from a team as a code owner October 31, 2023 17:06
terrytangyuan
terrytangyuan reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexmt
alexmt approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a01a1a) 49.54% compared to head (f1a8836) 49.55%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16184   +/-   ##
=======================================
  Coverage   49.54%   49.55%           
=======================================
  Files         269      269           
  Lines       46891    46891           
=======================================
+ Hits        23233    23236    +3     
+ Misses      21376    21374    -2     
+ Partials     2282     2281    -1

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.9

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) October 31, 2023 17:26
@crenshaw-dev crenshaw-dev merged commit d9e1b32 into argoproj:master Oct 31, 2023
25 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 31, 2023
@rpelczar
fix(ui): Missing data in Sync Status if application never been synced (…
8284858 
…#16184)

Signed-off-by: Rafal Pelczar <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 31, 2023
Merged
crenshaw-dev pushed a commit that referenced this pull request Oct 31, 2023
@gcp-cherry-pick-bot @rpelczar
fix(ui): Missing data in Sync Status if application never been synced (…
f29e4fb 
…#16184) (#16187)

Signed-off-by: Rafal Pelczar <[email protected]>
Co-authored-by: Rafal <[email protected]>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@rpelczar @jmilic1
fix(ui): Missing data in Sync Status if application never been synced (…
47fa4d9 
…argoproj#16184)

Signed-off-by: Rafal Pelczar <[email protected]>
Signed-off-by: jmilic1 <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@rpelczar @vladfr
fix(ui): Missing data in Sync Status if application never been synced (…
2ccc908 
…argoproj#16184)

Signed-off-by: Rafal Pelczar <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@rpelczar @tesla59
fix(ui): Missing data in Sync Status if application never been synced (…
57ca649 
…argoproj#16184)

Signed-off-by: Rafal Pelczar <[email protected]>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@rpelczar @lyda
fix(ui): Missing data in Sync Status if application never been synced (…
67eeb10 
…argoproj#16184)

Signed-off-by: Rafal Pelczar <[email protected]>
Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@rpelczar @Hariharasuthan99
fix(ui): Missing data in Sync Status if application never been synced (…
9969805 
…argoproj#16184)

Signed-off-by: Rafal Pelczar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpelczar @crenshaw-dev @alexmt @terrytangyuan